Implement materialization for RedshiftOfflineStore & RedshiftRetrievalJob #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsotne Tabidze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
===========================================
- Coverage 82.75% 69.10% -13.65%
===========================================
Files 76 76
Lines 6754 6817 +63
===========================================
- Hits 5589 4711 -878
- Misses 1165 2106 +941
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
woop
reviewed
Jul 5, 2021
added 3 commits
July 12, 2021 14:03
Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
woop
reviewed
Jul 14, 2021
woop
reviewed
Jul 14, 2021
Signed-off-by: Tsotne Tabidze <[email protected]>
|
/lgtm |
woop
approved these changes
Jul 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8bit-pixies
pushed a commit
to 8bit-pixies/feast
that referenced
this pull request
Jul 16, 2021
…lJob (feast-dev#1680) * Implement materialization for RedshiftOfflineStore Signed-off-by: Tsotne Tabidze <[email protected]> * Address Willem's comments Signed-off-by: Tsotne Tabidze <[email protected]> * Rename method Signed-off-by: Tsotne Tabidze <[email protected]> Signed-off-by: CS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: This PR makes it possible to materialize data from Redshift to online stores. Also added half of test_offline_online_store_consistency.py for Redshift (for now we're only asserting online store after materialization from Redshift and don't check offline store by calling get_historical_features, since that functionality is not yet implemented). This required implementing unload/copy logic through S3. RedshiftRetrievalJob is also fully implemented (to_df, to_arrow, to_s3, to_redshift).
Lastly, needed to add
iam_roleto the redshift config. This role is necessary for Redshift to access S3. It'll need to be setup by the user (both the role creation, and association to Redshift).Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: